[llvm][support] Fix DebugLogTest. #150585
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fails on windows with error C2466: cannot allocate an array of constant size 0 else.
|
@llvm/pr-subscribers-llvm-support Author: Jacques Pienaar (jpienaar) ChangesFails on windows with error C2466: cannot allocate an array of constant size 0 else. Full diff: https://github.com/llvm/llvm-project/pull/150585.diff 1 Files Affected:
diff --git a/llvm/unittests/Support/DebugLogTest.cpp b/llvm/unittests/Support/DebugLogTest.cpp
index 513699913f922..22dffd857613d 100644
--- a/llvm/unittests/Support/DebugLogTest.cpp
+++ b/llvm/unittests/Support/DebugLogTest.cpp
@@ -66,7 +66,7 @@ TEST(DebugLogTest, Basic) {
// LDBG should be compiled out in NDEBUG, so just check it compiles and has
// no effect.
llvm::DebugFlag = true;
- static const char *DT[] = {};
+ static const char *DT[] = {"A"};
setCurrentDebugTypes(DT, 0);
int count = 0;
auto inc = [&]() { return ++count; };
|
|
For reference, it also failed on GCC 13 with |
mahesh-attarde
pushed a commit
to mahesh-attarde/llvm-project
that referenced
this pull request
Jul 28, 2025
Fails on windows with error C2466: cannot allocate an array of constant size 0 else.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fails on windows with error
C2466: cannot allocate an array of constant size 0
else.